Fix matplotlib set_*lim API deprecations #3564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually happened in matplotlib? |
jni
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Gah! @hmaarrfk looks like it! https://matplotlib.org/api/_as_gen/matplotlib.axes.Axes.set_xlim.html
I was also incredulous so had to look it up.
I find this pretty terrible, but who am I to judge. Thanks for spotting this, @sciunto!
|
Before, the API was repetitive, now it sounds stupid (IMO). :( |
|
Perhaps the most natural calling convention then becomes |
|
@soupault Was my suggestion not a good one? :) |
|
@stefanv sorry, I didn't catch that you were suggesting to change the PR. Personally, I'm fine with the current implementation and don't really find |
|
On Wed, 28 Nov 2018 13:11:10 -0800, Egor Panfilov wrote:
@stefanv sorry, I didn't catch that you were suggesting to change the
PR. Personally, I'm fine with the current implementation and don't
really find `right`, `top`, etc stupid. But if you insist to revert
the PR and switch to unnamed arguments, I would mind.
No worries, I think this patch is fine. The new API in Matplotlib is
frustrating, though.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]
Checklist
[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
[For detailed information on these and other aspects see scikit-image contribution guidelines]
References
[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]
For reviewers
(Don't remove the checklist below.)
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x