add license notice change #180
Conversation
|
💖 Thanks for opening this pull request! 💖 |
There was a problem hiding this comment.
Is there a legal backing for doing this? Specifically, is there any precedent from other open source projects that we can use as a guide?
I'm imaging this being shared around on Linkedin or reddit and there will be mixed opinions on this. I do not want this licensing author change to stop people from contributing.
Edit: I meant "author change".
This is not a change of license. We have to be careful with wordings. |
We can always revert if an issue comes in.
I'd say it's the other way around. I remember working on issues and realizing no matter how much I work, my name is not gonna be on top of the file and that was a bit demotivating. We haven't been really adding names on top of the existing files for a long time really, and that means most active contributors are not there and they'd appreciate this change. |
|
As someone who's name is on many files and will be removed, I support this change.
These names do not reflect the full history of the files.
The original policy was designed without having in mind the huge growth of the community.
…On Apr 30, 2024, 10:17, at 10:17, Adrin Jalali ***@***.***> wrote:
> Specifically, is there any precedent from other open source projects
that we can use as a guide?
We can always revert if an issue comes in.
> I'm imaging this being shared around on Linkedin or reddit and there
will be mixed opinions on this. I do not want this licensing author
change to stop people from contributing.
I'd say it's the other way around. I remember working on issues and
realizing no matter how much I work, my name is not gonna be on top of
the file and that was a bit demotivating. We haven't been really adding
names on top of the existing files for a long time really, and that
means most active contributors are not there and they'd appreciate this
change.
--
Reply to this email directly or view it on GitHub:
#180 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
|
it's fine also for me. Less personal emails from students asking me to look at their code or explain them a function :) thanks @adrinjalali |
If we can revert, then I'm +1 on moving forward with the author change. |
|
Seems like we have enough +1s here, shall we merge? |
|
Congrats on merging your first pull request! 🎉 |
Following scikit-learn/scikit-learn#20813 (comment) , this is the public announcement that we'll be changing the license info in the codebase.