-
-
Notifications
You must be signed in to change notification settings - Fork 34
DOC Rename 'default' to 'native' for set_output SLEP #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving my proposal ;)
So |
Just for the context, refer to scikit-learn/scikit-learn#23734 (comment) Both "default" and "native" are not passepartout names. "Native" would imply that this is the native format given by the estimator that could optionally depend on the inputs. I would feel that "default" should mean a single type of output. But still, both terms are really generic and are used to define something that is ill-defined (if not reading the estimators' documentation). Bottom line, I don't have a strong opinion and I don't have a better proposal :) |
Would |
It was a proposal from @thomasjpfan and I would also be fine with it. |
As I already said
That means I favor a string that gives a hint at what it actually does. The meaning is - please correct me: A scikit-learn transformer outputs numpy.ndarray or scipy.sparse. This does not guarantee anything about 3rd party transformers. How about |
With the Array API PR, scikit-learn can also output I do not really like # By default, `est` returns an ndarray
est.transform(X_df) # this is an ndarray
est.set_output(transform="pandas")
est.transform(X_df) # this is a dataframe
est.set_output(transform="unchanged")
est.transform(X_df) # this is a ndarray?? I originally choose
Maybe... |
Some options for the default value of
|
After a good 🏃, I withdraw my concerns for |
so... close and leave as-is? I think in the end none of the words easily captures what's going on and folks will have to read the docs |
Agreed with @amueller. Closing then. |
Based on the discussion in scikit-learn/scikit-learn#23734 (review), reviewers concluded that "default" was not descriptive enough. The PR was updated to use
"native"
instead.