Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dp-derivation.rst isn't included in any toctree #10814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qinhanmin2014 opened this issue Mar 15, 2018 · 7 comments · Fixed by #10857
Closed

dp-derivation.rst isn't included in any toctree #10814

qinhanmin2014 opened this issue Mar 15, 2018 · 7 comments · Fixed by #10857
Labels
Documentation good first issue Easy with clear instructions to resolve help wanted

Comments

@qinhanmin2014
Copy link
Member

See Circle log:

/home/circleci/project/doc/modules/dp-derivation.rst: WARNING: document isn't included in any toctree

dp-derivation.rst is not included in user guide and relevant function will be removed in 0.20. Maybe we need to modify the file with latest api and integrate it into current user guide (or simply remove it?).
@jnothman
Copy link
Member

jnothman commented Mar 15, 2018 via email

@qinhanmin2014
Copy link
Member Author

I think it can be integrated into the user guide with latest api (maybe BayesianGaussianMixture?).
But I am OK with removing it, since I suspect whether users will benefit from these complex mathematical formulas.
@jnothman Do we need to wait for other opinions. Or you have made the final decision to remove it?

@jnothman
Copy link
Member

jnothman commented Mar 15, 2018 via email

@lesteve
Copy link
Member

lesteve commented Mar 16, 2018

I quickly search for dp-derivation and I found #7284 (comment) (this PR was never merged BTW and probably should be revived)
which seems to indicate that dp-derivation.rst is indeed only relevant to the deprecated gaussian mixture code.

git grep seems to confirm this. The only file mentioning dp-derivation.rst is sklearn/mixture/dpgmm.py, which I think is deprecated.

@qinhanmin2014
Copy link
Member Author

Thanks @lesteve for the detailed investigation. Seeing #7284, I'm now +1 of removing dp-derivation.rst.

@jnothman jnothman added good first issue Easy with clear instructions to resolve help wanted labels Mar 17, 2018
@gamazeps
Copy link
Contributor

If no one is assigned to the issue, can I do it as a first issue ?

@jnothman
Copy link
Member

jnothman commented Mar 18, 2018 via email

gamazeps added a commit to gamazeps/scikit-learn that referenced this issue Mar 22, 2018
@gamazeps
Removes dp-derivation.rst.
3eb3b7d 
The module is deprecated and will be removed in version 0.20.

Fixes scikit-learn#10814
gamazeps added a commit to gamazeps/scikit-learn that referenced this issue Mar 22, 2018
@gamazeps
Removes dp-derivation.rst.
f075cdf 
The module is deprecated and will be removed in version 0.20.

Fixes scikit-learn#10814
@gamazeps gamazeps mentioned this issue Mar 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation good first issue Easy with clear instructions to resolve help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG+1] Removes dp-derivation.rst. gamazeps/scikit-learn
4 participants
@jnothman @lesteve @gamazeps @qinhanmin2014