-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
OneHotEncoder "only non-negative integers" message should suggest using categories='auto' #12179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Easy
Well-defined and straightforward way to resolve
good first issue
Easy with clear instructions to resolve
Milestone
Comments
Can I take this issue? |
Sure, thanks!
|
ygivenx
pushed a commit
to ygivenx/scikit-learn
that referenced
this issue
Sep 27, 2018
OneHotEncoder "only non-negative integers" message should suggest using categories='auto'
ygivenx
pushed a commit
to ygivenx/scikit-learn
that referenced
this issue
Sep 27, 2018
OneHotEncoder "only non-negative integers" message should suggest using categories='auto'
ygivenx
pushed a commit
to ygivenx/scikit-learn
that referenced
this issue
Sep 27, 2018
OneHotEncoder "only non-negative integers" message should suggest using categories='auto'
Johanna and I am working on this. |
amueller
pushed a commit
that referenced
this issue
Oct 1, 2018
…) with negative integer values (#12180) * Fix Issue #12179 OneHotEncoder "only non-negative integers" message should suggest using categories='auto' * Fix Issue #12179 OneHotEncoder "only non-negative integers" message should suggest using categories='auto' * Fix Issue #12179 OneHotEncoder "only non-negative integers" message should suggest using categories='auto' * Fixes #12180 Modify the error message * Fix the spacing
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this issue
Oct 15, 2018
…) with negative integer values (scikit-learn#12180) * Fix Issue scikit-learn#12179 OneHotEncoder "only non-negative integers" message should suggest using categories='auto' * Fix Issue scikit-learn#12179 OneHotEncoder "only non-negative integers" message should suggest using categories='auto' * Fix Issue scikit-learn#12179 OneHotEncoder "only non-negative integers" message should suggest using categories='auto' * Fixes scikit-learn#12180 Modify the error message * Fix the spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Easy
Well-defined and straightforward way to resolve
good first issue
Easy with clear instructions to resolve
before version 0.20,
OneHotEncoder
did not support negative integers in input. Now it supports that case if the "new behaviour" is requested by instantiating it withcategories='auto'
. The legacy behaviour currently raisesValueError("X needs to contain only non-negative integers.")
. This error message should be extended to mention how the new behaviour can be activated.The text was updated successfully, but these errors were encountered: