Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve the plot in plot_ols_ridge_variance.py #12224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qinhanmin2014 opened this issue Sep 30, 2018 · 14 comments · Fixed by #12296
Closed

Improve the plot in plot_ols_ridge_variance.py #12224

qinhanmin2014 opened this issue Sep 30, 2018 · 14 comments · Fixed by #12296
Labels
Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted

Comments

@qinhanmin2014
Copy link
Member

See http://scikit-learn.org/dev/auto_examples/linear_model/plot_ols_ridge_variance.html
E.g., the titles and the plots are overlapping and the label of the axises are in the wrong place.
To dear contributor: please wait for #12199 before starting your work.
@qinhanmin2014 qinhanmin2014 added Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted labels Sep 30, 2018
@ab-10
Copy link

ab-10 commented Sep 30, 2018

Hi,
I'd like to take this once #12199 is merged.

@ogrisel
Copy link
Member

ogrisel commented Oct 1, 2018

I merged #12199.

@qinhanmin2014 qinhanmin2014 mentioned this issue Oct 1, 2018
Merged
@xhluca
Copy link
Contributor

xhluca commented Oct 3, 2018

@ab-10 Do you still wish to work on this one?

@dsprahul dsprahul mentioned this issue Oct 3, 2018
Closed
@dsprahul
Copy link

dsprahul commented Oct 3, 2018 •
edited
Loading

Hi,
This is my first contribution; is it okay if I just contribute without asking? What's the ideal practice?
Also, I'd be grateful if I could get a feedback on this contribution (community guidelines wise).

@qinhanmin2014
Copy link
Member Author

This is my first contribution; is it okay if I just contribute without asking? What's the ideal practice?

Your behavior is likely to make others (especially the two contributors above) unhappy.

@dsprahul
Copy link

dsprahul commented Oct 3, 2018 •
edited
Loading

This is my first contribution; is it okay if I just contribute without asking? What's the ideal practice?

Your behavior is likely to make others (especially the two contributors above) unhappy.

@qinhanmin2014 : Thanks, noted. I closed that pull request now.

@ab-10 / @ogrisel : Members made some comments on my implementation; you might want to take them into consideration while fixing this bug. (FYI)

@qinhanmin2014
Copy link
Member Author

@qinhanmin2014 : Thanks, noted. I closed that pull request now.

@RahulDamineni Are you still working on it? Otherwise I think @xhlulu or others might take it.

@dsprahul
Copy link

dsprahul commented Oct 3, 2018 •
edited
Loading

@qinhanmin2014 : I closed (cancelled) my previous pull request; others can work on it. Sorry for the confusion.

@xhluca
Copy link
Contributor

xhluca commented Oct 3, 2018

Yeah I'd like to work on it if @ab-10 can't work on it anymore

@qinhanmin2014
Copy link
Member Author

Yeah I'd like to work on it if @ab-10 can't work on it anymore

Thanks for contributing.

@ab-10
Copy link

ab-10 commented Oct 3, 2018

@xhlulu, sorry for missing this, have you begun working on it?

@xhluca
Copy link
Contributor

xhluca commented Oct 3, 2018 •
edited
Loading

@ab-10 I used another approach (plt instead of ax) and it works. However I haven't gotten started with the PR so you can go ahead and I can comment on it. Let me know

@xhluca
Copy link
Contributor

xhluca commented Oct 3, 2018

@qinhanmin2014 Slightly related to this, I've gone through the plot_out_of_core_classification.py tutorial recently and noticed some cosmetic irregularity (labels overlapping and cropped). Is it a good idea opening an issue about those kind of stuff? Thanks!

@qinhanmin2014
Copy link
Member Author

@qinhanmin2014 Slightly related to this, I've gone through the plot_out_of_core_classification.py tutorial recently and noticed some cosmetic irregularity (labels overlapping and cropped). Is it a good idea opening an issue about those kind of stuff? Thanks!

@xhlulu Feel free to submit PR directly. I'm opening issues to attract contributors.

@xhluca xhluca mentioned this issue Oct 5, 2018
Merged
@xhluca xhluca mentioned this issue Oct 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted
Projects
None yet
Milestone
No milestone
5 participants
@ogrisel @qinhanmin2014 @ab-10 @dsprahul @xhluca