[MRG+1] EXA Fixing plots for Out-of-core classification of text documents example #12359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qinhanmin2014 I mentioned this in this issue: #12224 |
|
Thanks, why WIP? |
|
That's right, labels on the middle would probably look better. I'll try it out and compare both tomorrow. Once it's done, I'll change the title to MRG if there isn't anything else that should be updated. |
|
Thoughts on centered axis? Will commit if it looks better: I personally think they look nicer, but I think the original author had reasons to not center it so will look more into it |
|
At least you'll have +1 from me if you center the labels :) |
|
Sounds good 😄 |
|
Thank you all! |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Oct 15, 2018
anuragkapale
pushed a commit
to anuragkapale/scikit-learn
that referenced
this pull request
Oct 23, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…documents example (scikit-learn#12359)" This reverts commit c3e96a7.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…documents example (scikit-learn#12359)" This reverts commit c3e96a7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
The current Out-of-core classification of text documents generates figures with overlapping and cropped label names. This fixes the problem by adjusting the layout (using
plt.tight_layout) for figure 3 and 4 and rotating the label for figure 3.Here are the current images:
Here are the new generated images:
Any other comments?