Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Including _criterion.pxd in the wheel to dervive new criterion #12363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glemaitre opened this issue Oct 12, 2018 · 3 comments
Closed

Including _criterion.pxd in the wheel to dervive new criterion #12363

glemaitre opened this issue Oct 12, 2018 · 3 comments
Labels
Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted
Milestone
0.20.1

Comments

@glemaitre
Copy link
Member

PR #10325 make it possible to derive a new criterion by exposing the RegressionCriterion and ClassificationCriterion. However, it seems that this PR does not make available the header file _criterion.pxd in the wheel. I was thinking that MANIFEST.in who do that but apparently not.

Checking scipy, I think that we should add the following sklearn/tree/setup.py

config.add_data_files('_criterion.pxd')

Is it the right way and do we want to do it?
@glemaitre glemaitre mentioned this issue Oct 12, 2018
Open
@jnothman jnothman added this to the 0.20.1 milestone Oct 14, 2018
@jnothman jnothman added the Easy Well-defined and straightforward way to resolve label Oct 14, 2018
@jnothman
Copy link
Member

I suspect so

@jnothman jnothman added good first issue Easy with clear instructions to resolve help wanted labels Oct 14, 2018
@RoopamSharma
Copy link
Contributor

Hi, I would like to work on this issue. I am contributing for the first time.

RoopamSharma added a commit to RoopamSharma/scikit-learn that referenced this issue Oct 14, 2018
@RoopamSharma
[Fix scikit-learn#12363]Included _criterion.pxd in the wheel to deriv…
ee88825 
…e new criterion
@jnothman
Copy link
Member

jnothman commented Oct 14, 2018 via email

@RoopamSharma RoopamSharma mentioned this issue Oct 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted
Projects
None yet
Milestone
0.20.1
Development

No branches or pull requests
3 participants
@jnothman @RoopamSharma @glemaitre