Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SparseCoder doesn't expose max_iter for Lasso #12650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrinjalali opened this issue Nov 22, 2018 · 3 comments · Fixed by #12682
Closed

SparseCoder doesn't expose max_iter for Lasso #12650

adrinjalali opened this issue Nov 22, 2018 · 3 comments · Fixed by #12682
Labels
Easy Well-defined and straightforward way to resolve Enhancement

Comments

@adrinjalali
Copy link
Member

SparseCoder uses Lasso if the algorithm is set to lasso_cd. It sets some of the Lasso's parameters, but not max_iter, and that by default is 1000. This results in a warning in examples/decomposition/plot_sparse_coding.py complaining that the estimator has not converged.

I guess there should be a way for the user to specify other parameters of the estimator used in SparseCoder other than the ones provided in the SparseCoder.__init__ right now.
@adrinjalali adrinjalali mentioned this issue Nov 23, 2018
Merged
@jnothman jnothman added Easy Well-defined and straightforward way to resolve Enhancement help wanted labels Nov 25, 2018
@jnothman
Copy link
Member

Are you thinking a lasso_kwargs parameter?

@adrinjalali
Copy link
Member Author

yeah, more like algorithm_kwargs I suppose, to cover Lasso, LassoLars, and Lars

But I was looking at the code to figure how many parameters are not covered by what's already given to SparseCoder, and there's not many. In fact, max_iter is a parameter to SparseCoder, not passed to LassoLars (hence the warning I saw in the example), and yet used when Lasso is used.

Looks like the intention has been to cover the union of parameters, but some may be missing, or forgotten to be passed to the underlying models.

@jnothman
Copy link
Member

jnothman commented Nov 26, 2018 via email

@adrinjalali adrinjalali mentioned this issue Nov 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve Enhancement
Projects
None yet
Milestone
No milestone
2 participants
@jnothman @adrinjalali