Thanks to visit codestin.com
Credit goes to github.com

Skip to content

OrdinalEncoder: Deprecate automatically assuming lexicographic ordering #14954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jnothman opened this issue Sep 11, 2019 · 7 comments
Open

OrdinalEncoder: Deprecate automatically assuming lexicographic ordering #14954

jnothman opened this issue Sep 11, 2019 · 7 comments
Labels
Easy Well-defined and straightforward way to resolve module:preprocessing

Comments

@jnothman
Copy link
Member

Currently, using OrdinalEncoder with a string-valued feature, and without categories explicitly specifying an order, means that OrdinalEncoder will number the categories according to their lexicographic ordering.

This is not appropriate if the categories have a natural ordering (e.g. ['Green', 'Amber', 'Red']) that can be harnessed by the downstream estimator.

Rather, we should allow the user to specify categories='arbitrary' or categories='lexicographic' or something to explicitly state that lexicographic ordering is okay. When the user specifies categories='auto' for a string-valued feature, OrdinalEncoder should raise a warning along the lines of DeprecationWarning("From version 0.24, OrdinalEncoder's categories='auto' setting will not work with string-valued features, and categories='arbitrary' or an explicit category order will be required.")
@jnothman jnothman added Easy Well-defined and straightforward way to resolve help wanted labels Sep 11, 2019
@jnothman jnothman mentioned this issue Sep 11, 2019
Closed
@venkyyuvy
Copy link
Contributor

Can I work on this?

@jnothman
Copy link
Member Author

jnothman commented Sep 12, 2019 via email

@Alexrand1
Copy link

Can you point me to where the file is located in the repo?

@thomasjpfan thomasjpfan mentioned this issue Sep 13, 2019
Closed
@venkyyuvy venkyyuvy mentioned this issue Sep 14, 2019
Closed
@PyExtreme
Copy link
Contributor

Hi, @venkyyuvy , Are you still working on this? Since, I am also interested to contribute.

Thanks

@venkyyuvy
Copy link
Contributor

yes @PyExtreme
I had raised a PR already, waiting for reviews!

This was referenced Nov 15, 2019
Open
Closed
@glemaitre
Copy link
Member

I think that #14984, #15050, and #15396 might not be blockers for 0.22 and I would move them for 0.23.

I think that it could be great to have a single issue (superseded #14953, #14954) to discuss the overall behaviour for categories in OneHotEncoder and OrdinalEncoder and from there having several PRs which follows the discussed proposals.

@glemaitre glemaitre mentioned this issue Nov 15, 2019
Open
jawadjawid added a commit to jawadjawid/scikit-learn that referenced this issue Mar 13, 2021
@jawadjawid
Add fix to scikit-learn#14954
eb528be
jawadjawid added a commit to jawadjawid/scikit-learn that referenced this issue Mar 13, 2021
@jawadjawid
Add unit tests to the fix of scikit-learn#14954
5a70e8a
@yahoyoungho
Copy link

@glemaitre Hi, random suggestion but what the function has a parameter named mapping that takes in a dictionary with keys being strings or some type of data and values being integers (either in a float or int form)?

@lucyleeow lucyleeow mentioned this issue May 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Sorting ordering option in OrdinalEncoder venkyyuvy/scikit-learn
7 participants
@jnothman @cmarmo @glemaitre @venkyyuvy @yahoyoungho @Alexrand1 @PyExtreme