-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Do we have a compelling reason to enforce tags? #18798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
FWIW, we start to use tags for our own test suite (e.g. run some checks on sampler supporting Dask array and dataframe). #18797 is indeed making the use of tag optional. However, it should be noticed that, currently, tags are enforced by using |
None that I can think of. I think you summarized the main points well. But we can also ask for feedback from maintainers of scikit-learn compatible projects, to get a better idea of how they feel about tags. |
Actually an issue where a developer of a third-package wanted to use tags programmatically in their own estimator. It might be difficult to find the comment through our issue tracker. |
Last year when I was working on a training on "how to write your own estimator" on a language usecase, since the input wasn't a numerical ndarray, and rather a list of strings, I had to use tags to pass |
Update: Tags are not a part of the public API via So I'd say we can move ahead with requiring tags. |
With #18797 we are making tags an optional requirement for third-party estimators. If there was a compelling reason to adopt tags, I would think that third-party developers would adopt it.
Currently, the tags are use to hold the metadata of an estimator. This is mostly use in our estimator checks.
One of the selling points is that the tags can replace the attributes we have in our estimators. We recently deprecated
_pairwise
attribute in #18143 . We are also working on deprecating_estimator_type
in #17806. In this point of view, the tags provide a namespace for provided metadata in estimators, which can be used by other libraries that ingest estimators.Are there any other reasons for third party developers to adopt tags?
The text was updated successfully, but these errors were encountered: