-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Track SLEP10: Add n_features_in_ to all modules #19333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@thomasjpfan How do we document |
I think we should add them to the docstring. I opened #19351 to start the process of documenting this.
I would say to deprecate it. |
Yep, this seems the right way. |
I was going for the compose module and it turns out n_features_in_ is already implemented for the TransformedTargetRegressor and ColumnTransformer, so the compose module can be removed from the list. This is done in #20175. |
TODO in subsequent PR:
|
Yeah!!! |
This issue tracks the status of follow-ups of #18514, i.e. the implementation of SLEP10.
According to
N_FEATURES_IN_AFTER_FIT_MODULES_TO_IGNORE
in test_common.py, as of 96a96f1, modules to ben_feature_in_
-ified are:Track documentation status of
n_features_in_
, seeN_FEATURES_MODULES_TO_IGNORE
in test_docstring_parameters.py, start was #19351. Note that existing alternatives liken_features_
attributes have to be properly deprecated:Note: for meta-estimators it is better to delegate feature consistency validation to the inner base estimators.
The text was updated successfully, but these errors were encountered: