TST Enables isotonic and manifold in test_check_n_features_in_after_fitting #19539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
ogrisel
approved these changes
Feb 25, 2021
|
I merged maybe a bit quickly. It might have made sense to also tackle the related document issues in the same PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #19333
What does this implement/fix? Explain your changes.
IsotonicRegression accepts 1d and 2d arrays with one feature. We do not have a
n_features_in_defined for this situation.manifoldestimators only hasfitandfit_transformfunctions, so it would passtest_check_n_features_in_after_fittingby default.