Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Q: doc svc.fit_status_ #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kingjr opened this issue May 7, 2015 · 7 comments · Fixed by #12427
Closed

Q: doc svc.fit_status_ #4687

kingjr opened this issue May 7, 2015 · 7 comments · Fixed by #12427
Labels
Documentation Easy Well-defined and straightforward way to resolve help wanted Sprint

Comments

@kingjr
Copy link
Contributor

kingjr commented May 7, 2015

I'm using 0.16.0 and trying to understand the svc.fit_status_ logic.

When it's correctly fitted it is = 0?

from sklearn.svm import SVC
from sklearn.datasets import make_classification

X, y = make_classification()
svc = SVC(kernel='linear')
svc.fit(X, y)
print(svc.fit_status_)

gives

0

Is this attribute going to be deprecated, or shall we clarify it in the documentation? In any case, what would you recommand to check whether a clf has been fitted?
@amueller
Copy link
Member

amueller commented May 7, 2015

This is an attribute of only SVC and it should probably be private. Thanks for pointing that out.
The same goes for probA_ and probB_ I think. The should all be renamed to leading and trailing underscore, I think (with a deprecation). If someone wants to tackle this, please also check if there are other undocumented properties after fitting.

And yes, 0 means correctly fitted. But if it is not zero, it will raise a warning.

@amueller amueller added Easy Well-defined and straightforward way to resolve Enhancement labels May 7, 2015
@kingjr
Copy link
Contributor Author

kingjr commented May 7, 2015

Ok Thanks.

@sonnyhu sonnyhu mentioned this issue May 31, 2015
Closed
@amueller
Copy link
Member

All attributes need documentation.

@andylamb
Copy link

andylamb commented Sep 7, 2015

This is still open?

@andylamb andylamb mentioned this issue Sep 7, 2015
Closed
@amueller amueller added the Sprint label Mar 3, 2017
@jhereth
Copy link

jhereth commented Oct 19, 2018

it seems the PR by @andylamb is almost finished. Unfortunately, his repository is gone.

Should I pick up the PR?

@amueller
Copy link
Member

sure go for it!

@jhereth jhereth mentioned this issue Oct 19, 2018
Merged
@jhereth
Copy link

jhereth commented Oct 20, 2018

@amueller thanks. It’s done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Easy Well-defined and straightforward way to resolve help wanted Sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Add documentation for SVC properties jhereth/scikit-learn
6 participants
@amueller @glouppe @lesteve @andylamb @kingjr @jhereth