[MRG] Add documentation for SVC properties #12427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rendering of the new attributes:
|
Closed
jnothman
approved these changes
Oct 21, 2018
eamanu
reviewed
Oct 22, 2018
| produce probability estimates from decision values. If | ||
| probability=False, an empty array. Platt scaling uses the logistic | ||
| function | ||
| ``1 / (1 + exp(decision_value * probA_ + probB_))`` |
There was a problem hiding this comment.
It would not be good to add blanks to separate the formula?
|
@eamanu Yes, I found Issue 4687. This is just to finish the original PR #5224 from @andylamb (incorporating the last review by @amueller). |
|
looks good to me. |
thoo
pushed a commit
to thoo/scikit-learn
that referenced
this pull request
Nov 14, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #4687
What does this implement/fix? Explain your changes.
The implementation of svm.SVC leaks some variables. In #4794 it was decided that it is not worth the effort to make these private. Instead they should be documented.
This PR provides the documentation
Any other comments?
Most work on this PR has been done by @andylamb in #5224. I only implemented the last review comment by @amueller after the PR was dormant for three years.