-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Remove the LDA reference in related packages now that we have it in scikit-learn? #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That one uses a collapsed gibbs sampler, ours is variational. We should change the reference to be explicit about that. ping @ariddell |
I didn't know there was a reference. Thanks! The algorithms (Gibbs vs. VB) are very different. |
Do you want to sent a PR that explains the difference in one or two sentences? It is more for the interested expert, I guess. |
Sure. I'll write a sentence or two. I need to add a link to the sklearn On 10/22, Andreas Mueller wrote:
|
I think that we should remove the pointer to LDA in
http://scikit-learn.org/dev/related_projects.html
What do people think?
The text was updated successfully, but these errors were encountered: