Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename Spectral Embedding to Laplacian Eigenmaps #5875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rohanp opened this issue Nov 18, 2015 · 4 comments
Closed

Rename Spectral Embedding to Laplacian Eigenmaps #5875

rohanp opened this issue Nov 18, 2015 · 4 comments
Labels
Documentation Easy Well-defined and straightforward way to resolve

Comments

@rohanp
Copy link

rohanp commented Nov 18, 2015

From what I understand from this and this paper on dimensionality reduction, spectral embeddings refer to any technique that conducts an eigendecomposition of an affinity matrix, not just Laplacian Eigenmaps. Those papers, and numerous other explicitly state the algorithms "spectral embedding" includes.

"... for spectral embedding algorithms such as metric multidimensional scaling (MDS) (Cox & Cox, 1994), spectral clustering (see Weiss, 1999, for a review), Laplacian eigenmaps, LLE, and Isomap..." 3

In fact, the sklearn documentation was the only source I could find that refers to laplacian eigenmaps and spectral embedding synonymously.

If I am correct, I propose renaming spectral embedding to laplacian eigenmaps, or, at the very least, correct the misleading documentation that says "Spectral Embedding (also known as Laplacian Eigenmaps)...".


"Spectral methods ... are able to reveal low dimensional structure in high dimensional data from the top or bottom eigenvectors of specially constructed matrices" 4

@amueller
Copy link
Member

From the literature (and the paper title of the reference) and Laurens van der Maaten's review, I tend to agree.
We can't just rename, we need to deprecate, though.

Alternatively, we could leave the class name and say explicitly in the docs "this class implements laplacian eigenmaps". Though the more explicit name is probably a better idea.

@raghavrv
Copy link
Member

raghavrv commented Aug 3, 2016

This needs to be closed too... @jnothman @amueller

@amueller amueller closed this as completed Aug 4, 2016
@amueller
Copy link
Member

I think we should mention the name laplacian eigenmap more prominently, though.

@amueller amueller reopened this Oct 13, 2016
@amueller amueller added Easy Well-defined and straightforward way to resolve Need Contributor labels Oct 13, 2016
@samsontmr
Copy link
Contributor

Hi! I'm new to skl and would like to contribute. Perhaps I could take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Easy Well-defined and straightforward way to resolve
Projects
None yet
Development

No branches or pull requests

4 participants