LatentDirichletAllocation perplexity method broken in version 0.18.1 #7954
Comments
|
Just want to add that I appreciate you looking into this, and thank you so much for your hard work in maintaining scikit-learn! |
|
Thanks for your detailed issue and the stand-alone example, just to say I can reproduce the problem. |
|
I'll volunteer to contribute the fix, since I believe I've identified where the problem is. I'll likely want to reach out to discuss implementation specifics as needed. Thanks! |
|
@garyForeman great, please open a pull-request to discuss there. |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this issue
Feb 28, 2017
…hod, Issue scikit-learn#7954 (scikit-learn#7992) Also deprecate doc_topic_distr argument in perplexity method
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this issue
Jun 14, 2017
…hod, Issue scikit-learn#7954 (scikit-learn#7992) Also deprecate doc_topic_distr argument in perplexity method
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this issue
Aug 11, 2017
…hod, Issue scikit-learn#7954 (scikit-learn#7992) Also deprecate doc_topic_distr argument in perplexity method
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this issue
Aug 19, 2017
…hod, Issue scikit-learn#7954 (scikit-learn#7992) Also deprecate doc_topic_distr argument in perplexity method
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this issue
Nov 15, 2017
…hod, Issue scikit-learn#7954 (scikit-learn#7992) Also deprecate doc_topic_distr argument in perplexity method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The perplexity method of the LatentDirichletAllocation class appears to have broken during the transition from scikit-learn 0.17.1 to 0.18.1. The values returned by the method are no longer consistent with the values printed during training iterations (verbose=1, evaluate_every=1).
Steps/Code to Reproduce
Gist with reproducible example can be found here: https://gist.github.com/garyForeman/321a10ebe29215a0c1acbcb4b320fb8e
Expected Results
Final perplexity printed during training should equal the value returned by the perplexity method when passed the training data.
Results when using 0.17.1:
iteration: 100, perplexity: 4044.2226
Train set perplexity: 4044.22258392
Actual Results
Results when using 0.18.1:
iteration: 100, perplexity: 4042.6522
Train set perplexity: 7592353.46945
Versions
Darwin-15.6.0-x86_64-i386-64bit
('Python', '2.7.12 |Anaconda custom (x86_64)| (default, Jul 2 2016, 17:43:17) \n[GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)]')
('NumPy', '1.11.2')
('SciPy', '0.18.1')
('Scikit-Learn', '0.18.1')
The text was updated successfully, but these errors were encountered: