Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Gradient boosting models ignore min_impurity_split parameter #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sebp opened this issue Dec 7, 2016 · 1 comment · Fixed by #8007
Closed

Gradient boosting models ignore min_impurity_split parameter #8006

sebp opened this issue Dec 7, 2016 · 1 comment · Fixed by #8007
Labels
Bug Easy Well-defined and straightforward way to resolve

Comments

@sebp
Copy link
Contributor

sebp commented Dec 7, 2016

Description

Gradient boosting models ignore min_impurity_split parameter introduced in commit 376aa50.

Expected Results

self.min_impurity_split should be passed to DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Actual Results

self.min_impurity_split is never read in BaseGradientBoosting or any of its sub-classes.

Versions

  • Linux-4.8.10-300.fc25.x86_64-x86_64-with-fedora-25-Twenty_Five
  • Python 3.5.2 |Continuum Analytics, Inc.| (default, Jul 2 2016, 17:53:06)
    [GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
  • NumPy 1.11.2
  • SciPy 0.18.1
  • Scikit-Learn @ 3dcb873
@amueller amueller added Bug Easy Well-defined and straightforward way to resolve Need Contributor labels Dec 7, 2016
@amueller
Copy link
Member

amueller commented Dec 7, 2016

Thanks for the report. Do you want to submit a fix with regression test?

@sebp sebp mentioned this issue Dec 7, 2016
Merged
sebp pushed a commit to sebp/scikit-learn that referenced this issue Dec 10, 2016
[MRG] Set min_impurity_split in gradient boosting models
50e30b2 
self.min_impurity_split should be passed to
DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Fixes scikit-learn#8006
sebp pushed a commit to sebp/scikit-learn that referenced this issue Dec 11, 2016
[MRG] Set min_impurity_split in gradient boosting models
5385982 
self.min_impurity_split should be passed to
DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Fixes scikit-learn#8006
sebp pushed a commit to sebp/scikit-learn that referenced this issue Dec 13, 2016
[MRG] Set min_impurity_split in gradient boosting models
c901cc5 
self.min_impurity_split should be passed to
DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Fixes scikit-learn#8006
sebp pushed a commit to sebp/scikit-learn that referenced this issue Dec 13, 2016
[MRG] Set min_impurity_split in gradient boosting models
b48fb08 
self.min_impurity_split should be passed to
DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Fixes scikit-learn#8006
jnothman pushed a commit that referenced this issue Dec 13, 2016
@sebp @jnothman
[MRG] Set min_impurity_split in gradient boosting models (#8007)
3162f98 
Fixes #8006
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this issue Feb 28, 2017
@sebp @sergeyf
[MRG] Set min_impurity_split in gradient boosting models (scikit-lear…
b825e84 
…n#8007)


Fixes scikit-learn#8006
@Przemo10 Przemo10 mentioned this issue Mar 17, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this issue Jun 14, 2017
@sebp @Sundrique
[MRG] Set min_impurity_split in gradient boosting models (scikit-lear…
2a43464 
…n#8007)


Fixes scikit-learn#8006
NelleV pushed a commit to NelleV/scikit-learn that referenced this issue Aug 11, 2017
@sebp @NelleV
[MRG] Set min_impurity_split in gradient boosting models (scikit-lear…
3e4a417 
…n#8007)


Fixes scikit-learn#8006
paulha pushed a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017
@sebp @paulha
[MRG] Set min_impurity_split in gradient boosting models (scikit-lear…
cabcd6b 
…n#8007)


Fixes scikit-learn#8006
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this issue Nov 15, 2017
@sebp @maskani-moh
[MRG] Set min_impurity_split in gradient boosting models (scikit-lear…
9120448 
…n#8007)


Fixes scikit-learn#8006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG + 1] Set min_impurity_split in gradient boosting models sebp/scikit-learn
update fork (#1)
2 participants
@sebp @amueller