Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Error in compare cross decomposition method #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eyalkr1 opened this issue Feb 7, 2017 · 2 comments · Fixed by #8578 · May be fixed by ja9harper/scikit-learn#1
Closed

Error in compare cross decomposition method #8307

eyalkr1 opened this issue Feb 7, 2017 · 2 comments · Fixed by #8578 · May be fixed by ja9harper/scikit-learn#1
Labels
Documentation Easy Well-defined and straightforward way to resolve Sprint

Comments

@eyalkr1
Copy link

eyalkr1 commented Feb 7, 2017

On this page
http://scikit-learn.org/stable/auto_examples/cross_decomposition/plot_compare_cross_decomposition.html#sphx-glr-auto-examples-cross-decomposition-plot-compare-cross-decomposition-py

The last lines has (copy-paste) error:
cca = CCA(n_components=2)
cca.fit(X_train, Y_train)
X_train_r, Y_train_r = plsca.transform(X_train, Y_train)
X_test_r, Y_test_r = plsca.transform(X_test, Y_test)

It should be cca.transform instead of plsca.transform
@lesteve
Copy link
Member

lesteve commented Feb 7, 2017 •
edited
Loading

I think you got this right, PR welcome!

While you are at it, you can use proper reST in the docstring of the example in order to have a better formatting (i.e. bullet points) for this:

Simple usage of various cross decomposition algorithms: - PLSCanonical - PLSRegression, with multivariate response, a.k.a. PLS2 - PLSRegression, with univariate response, a.k.a. PLS1 - CCA

@amueller amueller added Documentation Easy Well-defined and straightforward way to resolve Need Contributor Sprint labels Mar 4, 2017
@ja9harper
Copy link
Contributor

I will work on this.

This was referenced Mar 6, 2017
Open
Merged
raghavrv pushed a commit that referenced this issue Mar 12, 2017
@ja9harper @raghavrv
[MRG + 1] Correct typo in cross decomposition example (Fixes #8307) (#…
b4a12b1 
…8578)

* changed plsca to cca

* corrected variable plsca in line 56-57
@Przemo10 Przemo10 mentioned this issue Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this issue Mar 26, 2017
@ja9harper @herilalaina
[MRG + 1] Correct typo in cross decomposition example (Fixes scikit-l…
0648eb9 
…earn#8307) (scikit-learn#8578)

* changed plsca to cca

* corrected variable plsca in line 56-57
massich pushed a commit to massich/scikit-learn that referenced this issue Apr 26, 2017
@ja9harper
[MRG + 1] Correct typo in cross decomposition example (Fixes scikit-l…
2da9f59 
…earn#8307) (scikit-learn#8578)

* changed plsca to cca

* corrected variable plsca in line 56-57
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this issue Jun 14, 2017
@ja9harper @Sundrique
[MRG + 1] Correct typo in cross decomposition example (Fixes scikit-l…
aeea415 
…earn#8307) (scikit-learn#8578)

* changed plsca to cca

* corrected variable plsca in line 56-57
NelleV pushed a commit to NelleV/scikit-learn that referenced this issue Aug 11, 2017
@ja9harper @NelleV
[MRG + 1] Correct typo in cross decomposition example (Fixes scikit-l…
90c26cb 
…earn#8307) (scikit-learn#8578)

* changed plsca to cca

* corrected variable plsca in line 56-57
paulha pushed a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017
@ja9harper @paulha
[MRG + 1] Correct typo in cross decomposition example (Fixes scikit-l…
205b090 
…earn#8307) (scikit-learn#8578)

* changed plsca to cca

* corrected variable plsca in line 56-57
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this issue Nov 15, 2017
@ja9harper @maskani-moh
[MRG + 1] Correct typo in cross decomposition example (Fixes scikit-l…
1b9bcb0 
…earn#8307) (scikit-learn#8578)

* changed plsca to cca

* corrected variable plsca in line 56-57
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this issue Dec 18, 2017
@ja9harper
[MRG + 1] Correct typo in cross decomposition example (Fixes scikit-l…
f1a58ec 
…earn#8307) (scikit-learn#8578)

* changed plsca to cca

* corrected variable plsca in line 56-57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Easy Well-defined and straightforward way to resolve Sprint
Projects
None yet
Milestone
No milestone
5 participants
@amueller @lesteve @ja9harper @raghavrv @eyalkr1