Matplotlib update on CI makes example look different #8364

amueller · 2017-02-15T19:36:49Z

The examples look different on the current dev website, in particular the classifier comparison that's on the landing pages looks a bit odd now:
http://scikit-learn.org/dev/auto_examples/classification/plot_classifier_comparison.html

I suspect the culprit is the CI upgrading to matplotlib v2. I think we should go through the examples and see how they are holding up with the new styles.

amueller · 2017-02-15T19:38:51Z

this one for example doesn't show support vectors any more because edgecolor is "none" by default now: http://scikit-learn.org/dev/auto_examples/svm/plot_separating_hyperplane.html#sphx-glr-auto-examples-svm-plot-separating-hyperplane-py

rishikksh20 · 2017-02-15T19:45:08Z

let me look at it.

amueller · 2017-02-15T19:50:36Z

the hyperplane example might also use a serving of make_classification or make_blobs or at least a different random state because one of the points looks like it's a supportvector but not marked (but it's probably not a support vector by epsilon). Also fill_between might be nicer than the dotted lines? But that's probably a question of taste. The capital Y should be lower case though.

amueller · 2017-02-15T20:02:43Z

also that example should compute the margin as here: http://scikit-learn.org/dev/auto_examples/svm/plot_svm_margin.html#svm-margins-example I'm not sure the example is actually worth keeping with all of that ... seems redundant with the one I just linked to? but that one's also pretty broken on matplotlib v2

amueller · 2017-02-15T20:10:08Z

@jakevdp uses countourf pretty nicely for the margins: https://github.com/jakevdp/PythonDataScienceHandbook/blob/master/notebooks/05.07-Support-Vector-Machines.ipynb we should probably do that for the svm examples

NelleV · 2017-02-15T20:12:40Z

If you want to revert back to the old style it is possible, though I strongly recommend not to. Matplotlib 2.0 is so much nicer :D

amueller · 2017-02-15T20:15:00Z

I don't want to revert back, but many of the examples are now broken - because no-one bothered to check compatibility on our end :-/

NelleV · 2017-02-15T20:18:21Z

Yeah… There are changes I did not expect to see as well… I wonder if some don't underline a couple of bugs.

amueller · 2017-02-15T20:22:30Z

maybe someone should have looked at that at some point. I blame us ;)

rishikksh20 · 2017-02-15T21:04:59Z

Getting following result for SVM example after modifying it for matplotlib v2.0 and using contour for plotting:

@amueller Is it ok ?

rishikksh20 · 2017-02-16T21:23:19Z

Add edgecolors option in scatter plot Issue: #8364

Add edgecolors option in scatter plot Issue: scikit-learn#8364

amueller · 2017-03-03T21:46:15Z

Mentioning the issue in each commit is kinda spammy ;)

Have you submitted PRs for all of the ones that need fixing? Is not, which ones are still available?

rishikksh20 · 2017-03-04T05:50:27Z

@amueller I have submitted 4 to 5 PRs according to modules. Those files which are un-tick in my previous comment are available.

alisonspencer · 2017-03-04T16:07:42Z

I'll take a look at some of the examples that are still unchecked

amueller · 2017-03-04T16:16:39Z

@katelie please post which ones you're working on once you decided on it :)

* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364

rishikksh20 · 2017-03-04T16:38:07Z

@katelie All examples are arranged in modules in example's directory please take one module at a time and first checked the examples in the above list and then start working on them because I am also working this issue.

amueller · 2017-03-04T16:46:40Z

can someone please do http://scikit-learn.org/dev/auto_examples/classification/plot_classifier_comparison.html because it hurts my eyes on the frontpages ;) I'm not sure adding the marker edges is the right thing to do, it mostly looks odd because the reds seem to be different. But use your own judgment ;)

* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364

* Modify plot_cv_predict.py for matplotlib v2 comp Add `edgecolors` in scatter plot for matplotlib v2. Issue: #8364 * Modify plot_multilabel.py for matplotlib v2 Add `edgecolors` in scatterr plot for matplotlib v2. Issue: #8364 * Modify plot_kernel_ridge_regression for matplotlib v2 Add `edgecolors` in scatter plot and `makeredgecolor` in plot. Issue: #8364 * Modify plot_kernel_approximation.py for matplotlib v2 Add `edgecolors` in scatter plot for matplotlib v2. Issue: #8364 * Change plot_kernel_ridge_regression for better plot Remove `markeredgecolor` for better plot. Issue:#8364

* Modify plot_gpc_xor.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: #8364 * Modify plot_gpr_noisy.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: #8364 * Modify plot_gpr_prior_posterior for matplotlibv2 Add edgecolors attribute in scatter plot Issue: #8364 * Modify plot_gpc.py for matplotlib v2 comp Add edgecolors attribute in scatter plot. Issue: #8364 * Modify plot_gpr_noisy.py to remove flake8 error Modify file to pass travis build * Cosmetic change in plot_gpr_prior_posterior Reduce `alpha` for better plot. Issue: #8364 * Modify plot_gpr_noisy.py for better visualization Modify colorbar in contour plot. Issue: #8364

amueller · 2017-06-28T16:16:45Z

Maybe this one still?
http://scikit-learn.org/dev/auto_examples/tree/plot_iris.html#sphx-glr-auto-examples-tree-plot-iris-py

…8413) * Modify plot_cv_predict.py for matplotlib v2 comp Add `edgecolors` in scatter plot for matplotlib v2. Issue: scikit-learn#8364 * Modify plot_multilabel.py for matplotlib v2 Add `edgecolors` in scatterr plot for matplotlib v2. Issue: scikit-learn#8364 * Modify plot_kernel_ridge_regression for matplotlib v2 Add `edgecolors` in scatter plot and `makeredgecolor` in plot. Issue: scikit-learn#8364 * Modify plot_kernel_approximation.py for matplotlib v2 Add `edgecolors` in scatter plot for matplotlib v2. Issue: scikit-learn#8364 * Change plot_kernel_ridge_regression for better plot Remove `markeredgecolor` for better plot. Issue:scikit-learn#8364

…it-learn#8394) * Modify plot_gpc_xor.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: scikit-learn#8364 * Modify plot_gpr_prior_posterior for matplotlibv2 Add edgecolors attribute in scatter plot Issue: scikit-learn#8364 * Modify plot_gpc.py for matplotlib v2 comp Add edgecolors attribute in scatter plot. Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py to remove flake8 error Modify file to pass travis build * Cosmetic change in plot_gpr_prior_posterior Reduce `alpha` for better plot. Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py for better visualization Modify colorbar in contour plot. Issue: scikit-learn#8364

…8413) * Modify plot_cv_predict.py for matplotlib v2 comp Add `edgecolors` in scatter plot for matplotlib v2. Issue: scikit-learn#8364 * Modify plot_multilabel.py for matplotlib v2 Add `edgecolors` in scatterr plot for matplotlib v2. Issue: scikit-learn#8364 * Modify plot_kernel_ridge_regression for matplotlib v2 Add `edgecolors` in scatter plot and `makeredgecolor` in plot. Issue: scikit-learn#8364 * Modify plot_kernel_approximation.py for matplotlib v2 Add `edgecolors` in scatter plot for matplotlib v2. Issue: scikit-learn#8364 * Change plot_kernel_ridge_regression for better plot Remove `markeredgecolor` for better plot. Issue:scikit-learn#8364

…it-learn#8394) * Modify plot_gpc_xor.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: scikit-learn#8364 * Modify plot_gpr_prior_posterior for matplotlibv2 Add edgecolors attribute in scatter plot Issue: scikit-learn#8364 * Modify plot_gpc.py for matplotlib v2 comp Add edgecolors attribute in scatter plot. Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py to remove flake8 error Modify file to pass travis build * Cosmetic change in plot_gpr_prior_posterior Reduce `alpha` for better plot. Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py for better visualization Modify colorbar in contour plot. Issue: scikit-learn#8364

Add edgecolors option in scatter plot Issue: scikit-learn#8364

* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364

…8413) * Modify plot_cv_predict.py for matplotlib v2 comp Add `edgecolors` in scatter plot for matplotlib v2. Issue: scikit-learn#8364 * Modify plot_multilabel.py for matplotlib v2 Add `edgecolors` in scatterr plot for matplotlib v2. Issue: scikit-learn#8364 * Modify plot_kernel_ridge_regression for matplotlib v2 Add `edgecolors` in scatter plot and `makeredgecolor` in plot. Issue: scikit-learn#8364 * Modify plot_kernel_approximation.py for matplotlib v2 Add `edgecolors` in scatter plot for matplotlib v2. Issue: scikit-learn#8364 * Change plot_kernel_ridge_regression for better plot Remove `markeredgecolor` for better plot. Issue:scikit-learn#8364

…it-learn#8394) * Modify plot_gpc_xor.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: scikit-learn#8364 * Modify plot_gpr_prior_posterior for matplotlibv2 Add edgecolors attribute in scatter plot Issue: scikit-learn#8364 * Modify plot_gpc.py for matplotlib v2 comp Add edgecolors attribute in scatter plot. Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py to remove flake8 error Modify file to pass travis build * Cosmetic change in plot_gpr_prior_posterior Reduce `alpha` for better plot. Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py for better visualization Modify colorbar in contour plot. Issue: scikit-learn#8364

qinhanmin2014 · 2017-08-13T14:25:15Z

@amueller I updated plot_iris.html in #9541. Could you please have a look at it. Thanks:)

Add edgecolors option in scatter plot Issue: scikit-learn#8364

* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364

…8413) * Modify plot_cv_predict.py for matplotlib v2 comp Add `edgecolors` in scatter plot for matplotlib v2. Issue: scikit-learn#8364 * Modify plot_multilabel.py for matplotlib v2 Add `edgecolors` in scatterr plot for matplotlib v2. Issue: scikit-learn#8364 * Modify plot_kernel_ridge_regression for matplotlib v2 Add `edgecolors` in scatter plot and `makeredgecolor` in plot. Issue: scikit-learn#8364 * Modify plot_kernel_approximation.py for matplotlib v2 Add `edgecolors` in scatter plot for matplotlib v2. Issue: scikit-learn#8364 * Change plot_kernel_ridge_regression for better plot Remove `markeredgecolor` for better plot. Issue:scikit-learn#8364

…it-learn#8394) * Modify plot_gpc_xor.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py for matplotlib v2 comp Add edgecolors option in scatter plot Issue: scikit-learn#8364 * Modify plot_gpr_prior_posterior for matplotlibv2 Add edgecolors attribute in scatter plot Issue: scikit-learn#8364 * Modify plot_gpc.py for matplotlib v2 comp Add edgecolors attribute in scatter plot. Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py to remove flake8 error Modify file to pass travis build * Cosmetic change in plot_gpr_prior_posterior Reduce `alpha` for better plot. Issue: scikit-learn#8364 * Modify plot_gpr_noisy.py for better visualization Modify colorbar in contour plot. Issue: scikit-learn#8364

amueller · 2017-08-28T19:38:05Z

I think these are all done now.