Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Outlier detection common tests? #8677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Mar 31, 2017 · 6 comments
Closed

Outlier detection common tests? #8677

amueller opened this issue Mar 31, 2017 · 6 comments
Labels
Enhancement Moderate Anything that requires some knowledge of conventions and best practices Needs Decision - Close Requires decision for closing

Comments

@amueller
Copy link
Member

I think we should add some common tests for outlier detection, see #8676.
@amueller amueller added Enhancement Moderate Anything that requires some knowledge of conventions and best practices Need Contributor labels Mar 31, 2017
@albertcthomas
Copy link
Contributor

I agree. I'm already familiar with OneClassSVM, IsolationForest and LocalOutlierFactor. I can suggest common tests for outlier detection algorithms implemented in scikit-learn.

@albertcthomas albertcthomas mentioned this issue Apr 3, 2017
Closed
@jnothman
Copy link
Member

jnothman commented Apr 3, 2017 via email

@albertcthomas
Copy link
Contributor

I am currently working on this but I should maybe wait for PR #9015 as it is supposed to bring a bit more consistency between the different outlier detection algorithms. Or I can open a PR now and modify the tests once PR #9015 will be merged. Another possibility is that I work with @ngoix to add the common tests in PR #9015? or is it better to have two different PRs?

@lesteve
Copy link
Member

lesteve commented Jun 15, 2017

Shorter PRs are easier to review and thus tend to get merged quicker. I'd rather have 2 PRs.

@albertcthomas albertcthomas mentioned this issue Jul 3, 2017
Merged
@cmarmo cmarmo added the Needs Decision - Close Requires decision for closing label Dec 16, 2021
@cmarmo
Copy link
Contributor

cmarmo commented Dec 16, 2021

@albertcthomas does your #9270 close this issue? Thanks!

@albertcthomas
Copy link
Contributor

Yes let’s close this one. Thanks @cmarmo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Moderate Anything that requires some knowledge of conventions and best practices Needs Decision - Close Requires decision for closing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jnothman @amueller @cmarmo @lesteve @albertcthomas