-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
OneClassSVM returns float in predict #8676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm a new contributor to this repo, could I work on this? |
Hey @VathsalaAchar. Sure, go for it. |
I am new contributor and I am trying to learn my way around the code. I think I might have found the problem, in svm.cpp. Although the labels are 'int' Does it seem that I am on the right track? |
@mppaskov I don't think so. I think that we can just overide the predict function and change the type to int.
BaseSVC's predict function use the predict from BaseLibSVM, and BaseLibSVM is the only super class of OneClassSVM. |
@REM2016 Thank you for clarifying, I think went too deep into the rabbit hole. I was a bit skeptical of changing the underlying API calls in libsvm. |
@amueller I made the changes and the PR has been merged, just letting you know in case you want to close this issue. |
Thanks @VathsalaAchar ! |
It should return int to be consistent with the rest.
The text was updated successfully, but these errors were encountered: