Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG+1] OneClassSVM predict now returns int #8711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2017
Merged

[MRG+1] OneClassSVM predict now returns int #8711

merged 4 commits into from
Apr 6, 2017

Conversation

VathsalaAchar
Copy link
Contributor

Reference Issue #8676

The changes here fixes the OneClassSVM predict method. The method used to return float and now returns integer types.
Small changes to the test are also included.

If any further testing or documentation is required please let me know.

Vathsala Achar added 2 commits April 6, 2017 11:03
Added predict method to class OneClassSVM
060052b 
- This method overrides the default behaviour to only return integer class values.
Test for the change in OneClassSVM predict method
8532b02 
- small addition to test that the predicted result is integer
@VathsalaAchar VathsalaAchar changed the title OneClassSVM prediction type to int OneClassSVM predict now returns int Apr 6, 2017
@TomDLT
Copy link
Member

TomDLT commented Apr 6, 2017 •
edited
Loading

Your test is failing on windows 64bits.

Please also add an entry in doc/whats_new.rst.

@VathsalaAchar
Copy link
Contributor Author

VathsalaAchar commented Apr 6, 2017 •
edited
Loading

Hi @TomDLT I have made the necessary changes, could you have a look at the change to see if the Windows 64bit error will now be gone? I assumed it was from the int type check.

@TomDLT TomDLT changed the title OneClassSVM predict now returns int [MRG+1] OneClassSVM predict now returns int Apr 6, 2017
@TomDLT
Copy link
Member

TomDLT commented Apr 6, 2017

@VathsalaAchar The error is gone, thanks. Let's wait for a second review before merging.

@agramfort agramfort merged commit ebcfcaf into scikit-learn:master Apr 6, 2017
@agramfort
Copy link
Member

thx @VathsalaAchar

@VathsalaAchar VathsalaAchar deleted the oneclasssvm-prediction-type-to-int branch April 7, 2017 08:28
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Apr 8, 2017
@ivannz
Update to address scikit-learn#8711
81ab1f0
@ivannz ivannz mentioned this pull request Apr 9, 2017
Open
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Apr 17, 2017
@ivannz
Update to address scikit-learn#8711
e128437
massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
@VathsalaAchar
[MRG+1] OneClassSVM predict now returns int (scikit-learn#8711)
65a68a1 
* Added predict method to class OneClassSVM

- This method overrides the default behaviour to only return integer class values.

* Test for the change in OneClassSVM predict method

- small addition to test that the predicted result is integer

* Changed test to check for intp datatype

* Updated whats new
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Apr 26, 2017
@ivannz
Update to address scikit-learn#8711
25c274c
ivannz added a commit to ivannz/scikit-learn that referenced this pull request May 4, 2017
@ivannz
Update to address scikit-learn#8711
b8f08fd
ivannz added a commit to ivannz/scikit-learn that referenced this pull request May 15, 2017
@ivannz
Update to address scikit-learn#8711
8bc23eb
ivannz added a commit to ivannz/scikit-learn that referenced this pull request May 19, 2017
@ivannz
Update to address scikit-learn#8711
c2366ac
ivannz added a commit to ivannz/scikit-learn that referenced this pull request May 31, 2017
@ivannz
Update to address scikit-learn#8711
9b82d8b
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jun 8, 2017
@ivannz
Update to address scikit-learn#8711
86def95
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@VathsalaAchar @Sundrique
[MRG+1] OneClassSVM predict now returns int (scikit-learn#8711)
1cdaf3c 
* Added predict method to class OneClassSVM

- This method overrides the default behaviour to only return integer class values.

* Test for the change in OneClassSVM predict method

- small addition to test that the predicted result is integer

* Changed test to check for intp datatype

* Updated whats new
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jun 19, 2017
@ivannz
Update to address scikit-learn#8711
2ac496c
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jun 29, 2017
@ivannz
Update to address scikit-learn#8711
93d5344
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jul 19, 2017
@ivannz
Update to address scikit-learn#8711
750b487
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jul 29, 2017
@ivannz
Update to address scikit-learn#8711
1886a08
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@VathsalaAchar @NelleV
[MRG+1] OneClassSVM predict now returns int (scikit-learn#8711)
83cf611 
* Added predict method to class OneClassSVM

- This method overrides the default behaviour to only return integer class values.

* Test for the change in OneClassSVM predict method

- small addition to test that the predicted result is integer

* Changed test to check for intp datatype

* Updated whats new
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Aug 14, 2017
@ivannz
Update to address scikit-learn#8711
52c0baf
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Apr 23, 2019
@ivannz
Update to address scikit-learn#8711
dc885f4
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jul 25, 2019
@ivannz
Update to address scikit-learn#8711
878d518
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Aug 22, 2019
@ivannz
Update to address scikit-learn#8711
df03517
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Oct 5, 2019
@ivannz
Update to address scikit-learn#8711
5c3343a
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Oct 11, 2019
@ivannz
Update to address scikit-learn#8711
ede7563
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Nov 1, 2019
@ivannz
Update to address scikit-learn#8711
353ea2d
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jan 10, 2020
@ivannz
Update to address scikit-learn#8711
5c24f7e
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jan 30, 2020
@ivannz
Update to address scikit-learn#8711
559f956
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jan 30, 2020
@ivannz
Update to address scikit-learn#8711
9e5afd4
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Feb 27, 2020
@ivannz
Update to address scikit-learn#8711
4b56671
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Mar 12, 2020
@ivannz
Update to address scikit-learn#8711
1d8f3d7
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Apr 17, 2020
@ivannz
Update to address scikit-learn#8711
9b2db11
ivannz added a commit to ivannz/scikit-learn that referenced this pull request May 3, 2020
@ivannz
Update to address scikit-learn#8711
fb1b33c
ivannz added a commit to ivannz/scikit-learn that referenced this pull request May 30, 2020
@ivannz
Update to address scikit-learn#8711
81a7762
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jul 5, 2020
@ivannz
Update to address scikit-learn#8711
67a5b9e
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jul 5, 2020
@ivannz
Update to address scikit-learn#8711
d64ebbd
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Aug 5, 2020
@ivannz
Update to address scikit-learn#8711
a493fa9
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Oct 15, 2020
@ivannz
Update to address scikit-learn#8711
3d5cfad
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Nov 28, 2020
@ivannz
Update to address scikit-learn#8711
6acc573
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Dec 12, 2020
@ivannz
Update to address scikit-learn#8711
8f43f55
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Feb 25, 2021
@ivannz
Update to address scikit-learn#8711
f20f900
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Feb 25, 2021
@ivannz
Update to address scikit-learn#8711
ba8e357
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Mar 27, 2021
@ivannz
Update to address scikit-learn#8711
c08cedd
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jun 15, 2021
@ivannz
Update to address scikit-learn#8711
04d7764
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jul 23, 2021
@ivannz
Update to address scikit-learn#8711
1e122c4
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Nov 10, 2021
@ivannz
Update to address scikit-learn#8711
dd47253
ivannz added a commit to ivannz/scikit-learn that referenced this pull request May 15, 2022
@ivannz
Update to address scikit-learn#8711
bea1730
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Jun 14, 2022
@ivannz
Update to address scikit-learn#8711
a747ecf
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Aug 29, 2022
@ivannz
Update to address scikit-learn#8711
07211e1
ivannz added a commit to ivannz/scikit-learn that referenced this pull request Sep 5, 2022
@ivannz
Update to address scikit-learn#8711
d86b3fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VathsalaAchar @TomDLT @agramfort