Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Default 'solver' in LogisticRegressionCV is different from the one mentioned in the docs #9957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manikbhandari opened this issue Oct 19, 2017 · 3 comments · Fixed by #9962
Closed

Default 'solver' in LogisticRegressionCV is different from the one mentioned in the docs #9957

manikbhandari opened this issue Oct 19, 2017 · 3 comments · Fixed by #9962
Labels
Documentation good first issue Easy with clear instructions to resolve help wanted

Comments

@manikbhandari
Copy link

Description

In the documentation for LogisticRegressionCV, the source code at the top reads

solver='lbfgs'

whereas under the solver section it is written that the default is 'liblinear'. I was wondering which is the actual default and if I could send a PR to fix it!
@jnothman
Copy link
Member

jnothman commented Oct 19, 2017 via email

@lesteve lesteve added Documentation good first issue Easy with clear instructions to resolve help wanted labels Oct 19, 2017
@lesteve lesteve mentioned this issue Oct 19, 2017
Closed
@gustavodemari
Copy link
Contributor

The default is lbfgs, check the link below.

https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/logistic.py#L1558

@lesteve
Copy link
Member

lesteve commented Oct 20, 2017

PR more than welcome for fixing the docstring:

scikit-learn/sklearn/linear_model/logistic.py

Lines 1417 to 1419 in e0a2997

solver : {'newton-cg', 'lbfgs', 'liblinear', 'sag', 'saga'},
default: 'liblinear'
Algorithm to use in the optimization problem.

sam09 added a commit to sam09/scikit-learn that referenced this issue Oct 20, 2017
@sam09
Fix the default solver in the docstring of LogisticRegressionCV
594d4a9 
Fixes scikit-learn#9957
sam09 added a commit to sam09/scikit-learn that referenced this issue Oct 20, 2017
@sam09
Fix the default solver in the docstring of LogisticRegressionCV
dae7d02 
Fixes scikit-learn#9957
@sam09 sam09 mentioned this issue Oct 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation good first issue Easy with clear instructions to resolve help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG+1] Fix the default solver in the docstring of LogisticRegressionCV sam09/scikit-learn
4 participants
@jnothman @lesteve @gustavodemari @manikbhandari