[MRG + 1] adding sample weights for BayesianRidge #10112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Nov 12, 2017
|
please update what's new |
|
Looks fairly straightforward to me as well. Thanks for the contribution! |
|
Please add an entry to the change log at |
glemaitre
reviewed
Nov 12, 2017
sklearn/linear_model/bayes.py
Outdated
| sample_weight : numpy array of shape [n_samples] | ||
| Individual weights for each sample | ||
|
|
||
| .. versionadded:: 0.19.2 |
Codecov Report
@@ Coverage Diff @@
## master #10112 +/- ##
==========================================
+ Coverage 96.2% 96.2% +<.01%
==========================================
Files 337 337
Lines 62817 62827 +10
==========================================
+ Hits 60432 60442 +10
Misses 2385 2385
Continue to review full report at Codecov.
|
|
Thanks for the pointers on what's new! |
|
LGTM |
|
Thanks |
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab at adding sample_weight as a kwarg to BayesianRidge.
Seems to work well, and matches the Ridge.fit() method.
fixes #10111