I prefer scikit-learn be treated as a proper noun: don't put "the" before it.

Removed "the" from "the scikit-learn" in recent commit.

Good point @qinhanmin2014. For (1)

❯ git grep -iP 'the scikit[^-]'
doc/datasets/index.rst:The scikit also embed a couple of sample JPEG images published under Creative
examples/README.txt:General-purpose and introductory examples for the scikit.
examples/applications/wikipedia_principal_eigenvector.py:algorithm implemented in the scikit.
sklearn/__check_build/__init__.py:compile the scikit properly.
sklearn/__init__.py:    # We are not importing the rest of the scikit during the build
sklearn/preprocessing/label.py:    available in the scikit. A simple way to extend these algorithms
sklearn/preprocessing/label.py:    available in the scikit. A simple way to extend these algorithms

For (2) I could not find quickly looking at the matches a problem with "the scikit-learn". Generally there is a word afterwards like in "the scikit-learn project". I used this command: git grep -i -C1 'the scikit-learn'

@lesteve Thanks. Agree :)
@FarahSaeed Could you please extend the replacement ("the scikit" -> "scikit-learn") to other folders? Thanks.

@qinhanmin2014 Sure.

I'd say yes to #1; #2 is more minor, imo
But I also have no idea if others think this is the right thing to do

I think we all agree on this one ! @FarahSaeed all the matches I found are in #10126 (comment). You can run the same git grep command to make sure you removed all of them.

In recent commit, I've extended the replacement ("the scikit" -> "scikit-learn") to all folders.

@FarahSaeed Seems that there's still another one
sklearn/tests/test_common.py: # 'configure' functions in the setup.pys in the scikit
It might be better if you can use git grep or Linux grep to check your result :)

@qinhanmin2014 let me recheck and commit again.

Replaced "the scikit" with "scikit-learn" in all other places.

LGTM. I double-checked that there were no remaining "the scikit" occurences with git grep -iP 'the scikit[^-]'.

Merging without waiting for the CIs, thanks a lot @FarahSaeed !

Thank you! :) @lesteve @qinhanmin2014 @jnothman