Fix SGDClassifier never has the attribute "predict_proba" #10389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log or modified_huber loss) (scikit-learn#10113) - Changed predict_proba so that it checks the after-fitting estimator. - Added predict_proba as a property in MultiOutputClassifier
jnothman
reviewed
Jan 1, 2018
Member
jnothman
left a comment
There was a problem hiding this comment.
Please add a test. Also change the PR title to reflect that this is not about SGDClassifier.
| def _predict_proba(self, X): | ||
| check_is_fitted(self, 'estimators_') | ||
| if not hasattr(self.estimator, "predict_proba"): | ||
| if not hasattr(self.estimators_[0], "predict_proba"): |
Member
There was a problem hiding this comment.
These checks belong in the property definition for it to work.
Member
|
Are you still working on this? |
Member
|
fixed in #12222. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10113
What does this implement/fix? Explain your changes.
I implemented changes mentioned in the comment thread.
predict_proba, so that it checks the after-fitting estimator. i.e it checksself.estimators_[0]instead ofself.estimator.predict_probaas a property in MultiOutputClassifier class which makes its implementation similar to other classifiers.