[MRG] CI Reinstate docstring testing #10473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently this went missing in scikit-learn#9840
|
Good catch, Travis error seems like a genuine one. |
|
I don't understand how the tests for deprecation and delegation ever worked... They don't make much sense anyway, because they test on an instance rather than a class. |
|
Uhm that seems quite important ;) @jnothman could you have time to solve the conflicts |
|
@glemaitre are you +1 for merge? |
|
Sorry, misplaced click. Merge, @glemaitre? |
|
Yes please.
|
|
Found a computer back. Thanks @jnothman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently this went missing in #9840