Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update RFE to allow 2d output and non-finite inputs. #10822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update RFE to allow 2d output and non-finite inputs. #10822

wants to merge 2 commits into from

Conversation

jimmywan
Copy link
Contributor

Reference Issues/PRs

Fixes #10821 by relaxing checks that should be handled by downstream estimators.

Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests. It's very possible that old scipy won't work with some of the sparse matrix indexing, for instance... And have to check coef_ handling with multi-output y

@jimmywan
Copy link
Contributor Author

jimmywan commented May 9, 2018

FYI, I've stopped work on this PR.
I ended up rolling my own simple component that allowed me to do what I wanted to do in about 70 lines of code. I was able to get away with ignoring coef_ for multi-output y because I simply don't need to handle that case and figuring out what that entails.

I don't currently have the time/inclination to figure out exactly what needs to get done in order to make the tests handle sparse matrices and whatnot.

@jnothman
Copy link
Member

jnothman commented May 9, 2018

Thanks for checking in and for your work so far.

@jnothman
Copy link
Member

jnothman commented May 9, 2018

Also, I'd be fine to see this without multi-output support. The non-validation of X is more often useful, but it needs to be tested.

1 similar comment
@jnothman
Copy link
Member

jnothman commented May 9, 2018

Also, I'd be fine to see this without multi-output support. The non-validation of X is more often useful, but it needs to be tested.

@jimmywan
Copy link
Contributor Author

jimmywan commented Nov 5, 2019

This is no longer necessary. Superceded by #11635 .

@jimmywan jimmywan closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary call to check_X_y in RFE
2 participants