On 21 March 2018 at 22:45, Luis Galárraga ***@***.***> wrote: Reference Issues/PRs What does this implement/fix? Explain your changes. Any other comments? ------------------------------ You can view, comment on, or merge this pull request online at: #10848 Commit Summary - adding MDLP object to preprocessing folder - fixed the spacings between error messages - allowing mdlp to fit data in list format - fixed bug regarding floating point division - using more vectorized functions, and renamed variables - adding code to comply with scikit-learn guidelines - trying to resolve travis build failures - added more documentation, and renamed variables - more rigorous type checking using sklearn.utils - implemented mdlp with cut points, not intervals - got rid of partition_entropy function - randomizing order before sorting - added shuffle option - fixed bug with creating intervals - changed documentation, can now discretize 1-d arrays - MDLP: Added TransformerMixin parent class - MDLP: Added first test, need to add smaller test case - MDLP: Using Cython to speed up finding a good cut - MDLP: Adding checks for inputs to transform - MDLP: Edited setup.py file - MDLP: Added more cython code, reworded some docs and checks - MDLP: Removed unnecessary print statement, and updated cpp file File Changes - *A* sklearn/preprocessing/.gitignore <https://github.com/scikit-learn/scikit-learn/pull/10848/files#diff-0> (1) - *M* sklearn/preprocessing/__init__.py <https://github.com/scikit-learn/scikit-learn/pull/10848/files#diff-1> (2) - *A* sklearn/preprocessing/_mdlp.cpp <https://github.com/scikit-learn/scikit-learn/pull/10848/files#diff-2> (9232) - *A* sklearn/preprocessing/_mdlp.pxd <https://github.com/scikit-learn/scikit-learn/pull/10848/files#diff-3> (21) - *A* sklearn/preprocessing/_mdlp.pyx <https://github.com/scikit-learn/scikit-learn/pull/10848/files#diff-4> (151) - *A* sklearn/preprocessing/discretization.py <https://github.com/scikit-learn/scikit-learn/pull/10848/files#diff-5> (208) - *A* sklearn/preprocessing/setup.py <https://github.com/scikit-learn/scikit-learn/pull/10848/files#diff-6> (26) - *A* sklearn/preprocessing/tests/test_mdlp.py <https://github.com/scikit-learn/scikit-learn/pull/10848/files#diff-7> (186) Patch Links: - https://github.com/scikit-learn/scikit-learn/pull/10848.patch - https://github.com/scikit-learn/scikit-learn/pull/10848.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10848>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz6xzSf5zULIF5y68CIEL3ymuAlBPaks5tgj1wgaJpZM4SzawS> .