[MRG+1] Removes dp-derivation.rst.
#10857
Conversation
The module is deprecated and will be removed in version 0.20. Fixes scikit-learn#10814
There was a problem hiding this comment.
The PR itself LGTM. But @gamazeps , we now have 3 Circle jobs (python2, python3 and deploy, see recent PR). Seems that there's something wrong from your side?
|
@qinhanmin2014 I am new to circle-ci workflows so I may have misconfigured it in the web interface. I relaunched the build, and launched them on an up to date |
There was a problem hiding this comment.
LGTM. Thanks @gamazeps :)
We don't touch unrelevant examples in PR now so you won't get 403/500 errors
dp-derivation.rst.dp-derivation.rst.
@gamazeps please do not configure CircleCI on your fork. Now that you have please disable it. The reasons:
I don't know about the 500 errors (generally this is due to temporary glitches with mldata.org) but I can definitely reproduce locally the 403 errors from the Google finance API (examples/application/plot_stock_market.py). We should investigate them. The Google finance API URL that we use is kind of officially shut down last time I googled around, we need to find another way of getting this data. Searching for google finance API will very likely show more context. |
|
Aside from this the PR looks fine, merging, thanks a lot! |
Reference Issues/PRs
Fixes #10814
What does this implement/fix? Explain your changes.
This PR removes references to
dp-derivation.rstas it is only relevant to features currently deprecated which will be removed in 0.20
Any other comments?
The CircleCI tests do not pass, but due to 403 and 500 errors when fetching data, which
are not related in any way to the modified code.