[MRG+1] FIX make n_iter_ being the number of iteration performed #11015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
rth
reviewed
Apr 23, 2018
Member
rth
left a comment
There was a problem hiding this comment.
Minor comment below otherwise LGTM.
| sys.stdout = old_stdout | ||
|
|
||
|
|
||
| def test_gaussian_mixture_n_iter(): |
Member
There was a problem hiding this comment.
Maybe merge both test functions to a pytest parametrized test under sklearn/mixture/tests/test_mixture.py
Member
There was a problem hiding this comment.
Or actually somewhere under common tests and run it only for these two estimators for now?
Member
Author
There was a problem hiding this comment.
I was wondering about it and I think that this is good idea.
We should make an issue to make a common test across the estimator. But we need different data generation so I will make this tests for the moment.
Member
There was a problem hiding this comment.
It's also hard to make sure that the estimator does not converge...
jnothman
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #10740