Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG+1] Pytest parametrize part3 - feature_extraction, gaussian_process modules #11143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2018
Merged

[MRG+1] Pytest parametrize part3 - feature_extraction, gaussian_process modules #11143

merged 3 commits into from
Jun 4, 2018

Conversation

rth
Copy link
Member

@rth rth commented May 26, 2018

pytest parametrization of unit tests in sklearn.feature_extraction, sklearn.gaussian_process modules

Part 3 of #11074, please see the parent PR for additional information.

@rth rth changed the title Pytest parametrize part3 - feature_extraction, gaussian_process modules [MRG] Pytest parametrize part3 - feature_extraction, gaussian_process modules May 26, 2018
@rth rth mentioned this pull request May 26, 2018
Merged
3 tasks
qinhanmin2014
qinhanmin2014 approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sklearn/gaussian_process/tests/test_kernels.py Outdated
@pytest.mark.parametrize(
'kernel',
[kernel for kernel in kernels
if not (isinstance(kernel, KernelOperator) # skip non-basic kernels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the comment to the next line?

@qinhanmin2014 qinhanmin2014 changed the title [MRG] Pytest parametrize part3 - feature_extraction, gaussian_process modules [MRG+1] Pytest parametrize part3 - feature_extraction, gaussian_process modules May 29, 2018
@rth
Copy link
Member Author

rth commented May 29, 2018

Thanks for the review @qinhanmin2014 !

@qinhanmin2014
Copy link
Member

I'm going to merge this one
(1) I'll inteprete @lesteve 's approval in #11074 as the approval of this PR (since it's part of #11074 )
(2) There are not so many controversial things in part3 as in part1 and part2

@qinhanmin2014 qinhanmin2014 merged commit f049ec7 into scikit-learn:master Jun 4, 2018
@qinhanmin2014
Copy link
Member

Thanks @rth for the great work :)

@jnothman
Copy link
Member

jnothman commented Jun 4, 2018 via email

@rth rth deleted the pytest-parametrize-part3 branch July 15, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rth @qinhanmin2014 @jnothman