[MRG] Fix some example refs due to renaming examples #11214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
amueller
approved these changes
Jun 6, 2018
|
Regarding hetero_feature_union.py, I think it's replaces by column_transformer.py in #9012, but I'll need some time to check these two examples before submitting PR, or someone else involving in that PR might do it right now. |
|
Thanks @amueller and @qinhanmin2014 for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of broken link that can be seen on the dev doc (search for
sphx_glr).It's really hard to remember to check for sphinx references when moving around the examples ...
Another broken link I found in the FAQ. Not sure what the proper replacement link is because the example does not exist anymore ...