Fix #11219: DOC instructions for changing default value of certain parameters #11283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f vertain parameter
|
Maybe use a simpler example or make up an example. There is a lot of code that doesn't really illustrate the issue well. It would be good to change how the default value is changed to |
…lified the example.
amueller
reviewed
Jun 15, 2018
doc/developers/contributing.rst
Outdated
| warnings.warn("'n_estimators''s default value was changed to 100 | ||
| n=100): | ||
| n = n | ||
| warnings.warn("'n_estimators''s default value was changed to 100 |
There was a problem hiding this comment.
the warning should be in fit, not init.
There was a problem hiding this comment.
|
@amueller, I've sometimes been against using None as the placeholder value.
I prefer 'deprecated' or 'old-value-warn'. I find None is too semantically
opaque.
|
|
@jnothman I'm happy to have |
|
@melrchen are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11219
Added some instructions in the dev guide with an example to show how to change the default value of certain parameters and add a deprecation warning for other users.