Fixes sign of logdet_sigma term in BayesianRidge.fit #11294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
you can add the regression test in sklearn/linear_model/tests/test_bayes.py. This test should check on a small example that the formula is now correct; the test should pass on this branch and fail on master. |
Contributor
Author
|
Didn't see that PR, but I'll add a test in the next few days. |
Contributor
|
Any idea how big of a problem this bug is? |
Member
|
Ping for test ;) |
6 tasks
Contributor
|
I added a non regression test in PR #12174. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10748
What does this implement/fix? Explain your changes.
Implements the fix for the bug reported in the issue above. Tests pass. I am open to trying to add a regression test with some guidance on how to do so effectively.
Any other comments?