-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG] ChainedImputer -> IterativeImputer, and documentation update #11350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jnothman
merged 30 commits into
scikit-learn:iterativeimputer
from
sergeyf:chained_imputer_update
Sep 16, 2018
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0e415aa
first commit
sergeyf 5445012
complete functional overhaul
sergeyf 3a2d510
fixing some documentation
sergeyf bf58d92
fixing broken test
sergeyf 45f228c
addressing review comments + stef's suggestions for documentation
sergeyf b231b05
fixing docs
sergeyf ecfac5c
more update to impute.rst
sergeyf 5b2b181
name change again, new default ridgeCV
sergeyf cbbc8b0
small bug
sergeyf 0c9f64f
output changed in impute.rst because of RidgeCV
sergeyf c0c6a4c
Update impute.rst a smidge.
sergeyf c4ccdfc
Remove pre-clipping
sergeyf 3c882e7
addressing comments
sergeyf 8afdd2f
forgotten doc change
sergeyf b61fc1f
typo
sergeyf 482e9a5
addressing comments
sergeyf f6a7f45
fixing docs from review
sergeyf 59d97e1
Merge branch 'master' into chained_imputer_update
sergeyf 5bc04d9
Merge remote-tracking branch 'origin/master' into chained_imputer_update
glemaitre 8bd5e2c
TST update tests with renaming
glemaitre 65f43a7
iter
glemaitre 7604677
Merge remote-tracking branch 'origin/master' into chained_imputer_update
glemaitre fac9839
Missing rename
sergeyf b772a5a
Merge branch 'iterativeimputer' into chained_imputer_update
sergeyf 0ba454c
Undoing changes to 0.20 rst
sergeyf 3744445
Updating 0.21 changes to IterativeImputer
sergeyf 5d6865d
Update v0.20 rst to not have any changes
sergeyf 24bb77b
Fix plot_missing_values.py
sergeyf 12a3456
Addressing review comments
sergeyf 222b269
Fixed :class: syntax
sergeyf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a small description on the parameter which are important:
n_iter
might be probably enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added in above paragraph.