Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[NOMRG] TST Use SimpleImputer instead of Imputer in test_bagging.py #11480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[NOMRG] TST Use SimpleImputer instead of Imputer in test_bagging.py #11480

wants to merge 1 commit into from

Conversation

qinhanmin2014
Copy link
Member

preprocessing.Imputer is deprecated.
Will check and merge when green.

@qinhanmin2014
Copy link
Member Author

CIs are failing, interesting o(╥﹏╥)o

@qinhanmin2014 qinhanmin2014 added this to the 0.20 milestone Jul 11, 2018
@qinhanmin2014 qinhanmin2014 mentioned this pull request Jul 11, 2018
Closed
@qinhanmin2014
Copy link
Member Author

I'm not familiar enough with relevant PRs so I opened #11482 for further discussion.

@qinhanmin2014
Copy link
Member Author

Oops, I'll reopen to make the logs from Appveyor available.

@qinhanmin2014 qinhanmin2014 reopened this Jul 11, 2018
@qinhanmin2014 qinhanmin2014 changed the title TST Use SimpleImputer instead of Imputer in test_bagging.py [NOMRG] TST Use SimpleImputer instead of Imputer in test_bagging.py Jul 15, 2018
@qinhanmin2014 qinhanmin2014 removed this from the 0.20 milestone Jul 16, 2018
@amueller
Copy link
Member

why did you remove this from the release? It's blocking #11570 btw

@qinhanmin2014
Copy link
Member Author

@amueller #11482 is still in 0.20.
I remove this one because it seems that there's consensus to allow the regression, note it down and modify existing tests. In this case, this PR becomes useless. I keep it open to let others view the logs.

@amueller
Copy link
Member

thanks. fixed in #11593.

@qinhanmin2014 qinhanmin2014 deleted the test-bagging branch July 18, 2018 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

Assignees
No one assigned
Labels
Blocker Bug Build / CI help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinhanmin2014 @amueller @jnothman