[MRG+1] fetch_openml should support return_X_y #11840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
pep8 errors |
Member
|
You need to add a test case to sklearn/datasets/tests/test_openml.py |
Contributor
Author
|
Both done. |
sklearn/datasets/openml.py
Outdated
| return_X_y : boolean, default=False. | ||
| If True, returns ``(data, target)`` instead of a Bunch object. | ||
| See below for more information about the `data` and `target` object |
Member
There was a problem hiding this comment.
No extra indentation is needed here (the "See .." should align with "If True ...")
object -> objects
qinhanmin2014
approved these changes
Aug 18, 2018
sklearn/datasets/openml.py
Outdated
| categories=nominal_attributes, | ||
| url="https://www.openml.org/d/{}".format(data_id)) | ||
|
|
||
| if return_X_y: |
Member
There was a problem hiding this comment.
Maybe put it above bunch = Bunch(...)
Member
|
Please add an entry to the change log at |
Member
|
I don't think it's useful to the user to have a what's new entry for this
given that the function is not released
|
rth
approved these changes
Aug 18, 2018
Contributor
Author
|
OK, I'm on it. |
Member
|
I'll merge this one and open a PR myself to update the examples. Thanks @VUFG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #11814. See also #11466.
What does this implement/fix? Explain your changes.
Modify fetch_openml to support return_X_y parameter.
Add return_X_y test in test_openml.py
Any other comments?