[MRG] FIX Use take instead of choose #12165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Sep 26, 2018
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM besides the non-regression test could be made more intuitive.
| # Non-regression smoke test for #12146 | ||
| y = np.arange(50) | ||
| weight = compute_sample_weight('balanced', y, indices=np.arange(50)) | ||
| assert len(np.unique(weight)) |
Member
There was a problem hiding this comment.
I don't understand the intent of this assertion. The following looks more natural to me:
n_classes = 50 # more than 32 distinct classes
y = np.arange(n_classes) # one sample for each class
indices = np.arange(n_classes) # disable subsampling explicitly
weight = compute_sample_weight('balanced', y, indices)
assert_allclose(weight, np.ones(y.shape[0]))
Member
|
I think we should backport this fix for 0.20.1. Meaning the whats new entry should be written accordingly. |
Member
Author
I don't mind much either way but have moved what's new. Do we have a 0.20.1 PR open? |
jnothman
added a commit
to jnothman/scikit-learn
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12146