Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH Raise an error when pos_label is not in binary y_true #12313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2018
Merged

ENH Raise an error when pos_label is not in binary y_true #12313

merged 2 commits into from
Oct 8, 2018

Conversation

qinhanmin2014
Copy link
Member

Part of #12312
Note to reviewer: _average_binary_score will raise an error at the beginning if y_true is not binary or multilabel-indicator so we don't need to raise an error in average_precision_score.

jnothman
jnothman approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a test for the len(present_labels) == 1 case then this lgtm

NicolasHug
NicolasHug reviewed Oct 8, 2018
View reviewed changes
sklearn/metrics/tests/test_ranking.py Outdated
y_true = np.array([0, 1])
y_pred = np.array([0, 1])
erorr_message = ("pos_label=2 is invalid. Set it to a label in y_true.")
assert_raise_message(ValueError, erorr_message, average_precision_score,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erorr -> error (there's the same typo line 696)

@qinhanmin2014
Copy link
Member Author

If there is a test for the len(present_labels) == 1 case then this lgtm

@jnothman we have such a test

y_true = [1, 1]
y_score = [0.25, 0.75]
p, r, _ = precision_recall_curve(y_true, y_score)
assert_almost_equal(average_precision_score(y_true, y_score), 1.)
assert_array_almost_equal(p, [1., 1., 1.])
assert_array_almost_equal(r, [1, 0.5, 0.])

@qinhanmin2014 qinhanmin2014 mentioned this pull request Oct 8, 2018
Closed
@qinhanmin2014 qinhanmin2014 merged commit 5fd9e03 into scikit-learn:master Oct 8, 2018
@qinhanmin2014 qinhanmin2014 deleted the AP-error-message branch October 9, 2018 13:23
@amueller amueller mentioned this pull request Nov 20, 2018
Merged
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Nov 20, 2018
@qinhanmin2014 @jnothman
ENH Raise an error when pos_label is not in binary y_true (scikit-lea…
9b998a0 
…rn#12313)
@EJueon EJueon mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinhanmin2014 @jnothman @NicolasHug