Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] Move RandomTreesEmbedding criterion & max_features to be class attributes #12324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2018
Merged

[MRG] Move RandomTreesEmbedding criterion & max_features to be class attributes #12324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f118b76
rm criterion and max_features from __init__ and store them as class a…
rohan-varma Oct 8, 2018
d1b67dc
make sure that the docstring comes first
rohan-varma Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sklearn/ensemble/forest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1896,6 +1896,9 @@ class RandomTreesEmbedding(BaseForest):

"""

criterion = 'mse'
max_features = 1

def __init__(self,
n_estimators='warn',
max_depth=5,
Expand Down Expand Up @@ -1925,12 +1928,10 @@ def __init__(self,
verbose=verbose,
warm_start=warm_start)

self.criterion = 'mse'
self.max_depth = max_depth
self.min_samples_split = min_samples_split
self.min_samples_leaf = min_samples_leaf
self.min_weight_fraction_leaf = min_weight_fraction_leaf
self.max_features = 1
self.max_leaf_nodes = max_leaf_nodes
self.min_impurity_decrease = min_impurity_decrease
self.min_impurity_split = min_impurity_split
Expand Down