Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the link to computing docs on README #12380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gustavodemari
Copy link
Contributor

What does this implement/fix? Explain your changes.

On the release of scikit 0.20, the computing docs file have changed from "computational_performance.rst" to "computing.rst"

https://github.com/scikit-learn/scikit-learn/blob/0.20.X/doc/modules/computing.rst
https://github.com/scikit-learn/scikit-learn/blob/0.19.X/doc/modules/computational_performance.rst

In consequence, the link from README.rst pointing to the Linear Algebra section in the Computing page wasn't working because it was pointing to the old link.

So, this PR fixes the broken link of the computing section on the README.rst.

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gustavodemari
Appveyor failure unrelated.

@qinhanmin2014 qinhanmin2014 merged commit 906f078 into scikit-learn:master Oct 15, 2018
anuragkapale pushed a commit to anuragkapale/scikit-learn that referenced this pull request Oct 23, 2018
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Nov 14, 2018
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants