-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
MNT skip test falling on master in legacy platforms #12382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wonder why that operation is safe on 32-bit linux, but not on 32-bit windows. |
Or rather, why linux does not require safe casting. |
@@ -448,14 +448,6 @@ def test_count_nonzero(): | |||
assert (count_nonzero(X_csr, axis=0, sample_weight=sample_weight).dtype == | |||
count_nonzero(X_csr, axis=1, sample_weight=sample_weight).dtype) | |||
|
|||
# Check dtypes with large sparse matrices too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better than this (but perhaps still not ideal) would be to have this all in a try-except block, catching and passing if the error message contains "according to the rule 'safe'" and if np.intp().nbytes < 8
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM from my side and I can't figure out a better solution.
This reverts commit db1dca4.
ping @jnothman CIs are green (though not sure why codecov fails), ready for another review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Codecov doesn't get stats from windows runs. |
I'm merging this to fix master, to avoid confusion for contributors, especially since it seems to apply to the ending python 2 |
…earn#12382)" This reverts commit 4b47ef5.
…earn#12382)" This reverts commit 4b47ef5.
Apologies an accident in Appveyor prevent me from seeing this error (python2.7 32bit Appveyor).
I'm unable to come up with a good solution, maybe remove the test is acceptable since we already have one for normal csr matrix, or we can skip it on 32bit machine, but I'm not sure when it will happen.
ping @jnothman