Fix #12398: DecisionTreeClassifier does not support categorical data #12402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Oct 18, 2018
doc/modules/tree.rst
Outdated
| @@ -400,7 +400,7 @@ it differs in that it supports numerical target variables (regression) and | |||
| does not compute rule sets. CART constructs binary trees using the feature | |||
| and threshold that yield the largest information gain at each node. | |||
|
|
|||
| scikit-learn uses an optimised version of the CART algorithm. | |||
| scikit-learn uses an optimised version of the CART algorithm; however, scikit-learn implementation does not support categorical variables for now. | |||
There was a problem hiding this comment.
Please break lines so that they don't exceed 79 characters
jnothman
approved these changes
Oct 18, 2018
|
Thanks @pulkitmaloo |
anuragkapale
pushed a commit
to anuragkapale/scikit-learn
that referenced
this pull request
Oct 23, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 14, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#12402)" This reverts commit d0234e6.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#12402)" This reverts commit d0234e6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12398
What does this implement/fix? Explain your changes.
Updated DecisionTreeClassifier doc to mention that it does not support categorical data for now
Any other comments?