Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] MNT Change default metric in OPTICS #12439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2018
Merged

[MRG] MNT Change default metric in OPTICS #12439

merged 2 commits into from
Oct 23, 2018

Conversation

qinhanmin2014
Copy link
Member

part of #12437
Change the default metric from euclidean to minkowski because
(1) We have parameter p here.
(2) euclidean from scikit-learn is not robust.

@qinhanmin2014 qinhanmin2014 changed the title MNT Change default metric in OPTICS [MRG] MNT Change default metric in OPTICS Oct 23, 2018
@TomDLT TomDLT mentioned this pull request Oct 23, 2018
Open
@jnothman jnothman merged commit be742c3 into scikit-learn:master Oct 23, 2018
@qinhanmin2014 qinhanmin2014 deleted the OPTICS_default_metric branch October 23, 2018 13:50
thoo pushed a commit to thoo/scikit-learn that referenced this pull request Nov 14, 2018
@qinhanmin2014 @thoo
MNT Change default metric in OPTICS (scikit-learn#12439)
58a5bfd
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@qinhanmin2014
MNT Change default metric in OPTICS (scikit-learn#12439)
a21df77
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MNT Change default metric in OPTICS (scikit-learn#12439)"
51a1fcd 
This reverts commit a21df77.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MNT Change default metric in OPTICS (scikit-learn#12439)"
3ea060d 
This reverts commit a21df77.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@qinhanmin2014 @koenvandevelde
MNT Change default metric in OPTICS (scikit-learn#12439)
111279a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinhanmin2014 @jnothman @TomDLT