Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG+2] FIX olivetti_faces DESCR to point to the good location #12441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2018
Merged

[MRG+2] FIX olivetti_faces DESCR to point to the good location #12441

merged 2 commits into from
Oct 23, 2018

Conversation

jeremiedbb
Copy link
Member

Fixes #12440

Comes from a bad copy paste...

it would be nice to have a backport in 0.20.1, since it was introduce in 0.20, to not provide wrong informations for too long.

@jeremiedbb jeremiedbb mentioned this pull request Oct 23, 2018
Closed
rth
rth approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth added this to the 0.20.1 milestone Oct 23, 2018
qinhanmin2014
qinhanmin2014 approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a what's new entry

@qinhanmin2014 qinhanmin2014 changed the title [MRG] FIX olivetti_faces DESCR to point to the good location [MRG+2] FIX olivetti_faces DESCR to point to the good location Oct 23, 2018
@qinhanmin2014 qinhanmin2014 merged commit 013d295 into scikit-learn:master Oct 23, 2018
@jeremiedbb jeremiedbb deleted the fix-olivetti-DESCR branch October 24, 2018 11:53
thoo pushed a commit to thoo/scikit-learn that referenced this pull request Nov 14, 2018
@jeremiedbb @thoo
FIX olivetti_faces DESCR to point to the good location (scikit-learn#…
5f5c3ac 
…12441)
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Nov 14, 2018
@jeremiedbb @jnothman
FIX olivetti_faces DESCR to point to the good location (scikit-learn#…
bb57aaa 
…12441)
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Nov 14, 2018
@jeremiedbb @jnothman
FIX olivetti_faces DESCR to point to the good location (scikit-learn#…
a57ef83 
…12441)
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@jeremiedbb
FIX olivetti_faces DESCR to point to the good location (scikit-learn#…
1a8c267 
…12441)
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "FIX olivetti_faces DESCR to point to the good location (sciki…
f350298 
…t-learn#12441)"

This reverts commit 1a8c267.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "FIX olivetti_faces DESCR to point to the good location (sciki…
37a1597 
…t-learn#12441)"

This reverts commit 1a8c267.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@jeremiedbb @koenvandevelde
FIX olivetti_faces DESCR to point to the good location (scikit-learn#…
a7df444 
…12441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @rth @qinhanmin2014