Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST Ignore Kmeans test failures on MacOS #12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2019
Merged

TST Ignore Kmeans test failures on MacOS #12648

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9b75b0
TST Ignore Kmeans test failures on MacOS
qinhanmin2014 Nov 22, 2018
0c96424
Merge remote-tracking branch 'upstream/master' into kmeans-test
qinhanmin2014 Apr 30, 2019
9bfbe14
Add comment about test redundancy and purpose
jnothman Apr 30, 2019
96f75a0
line length
jnothman Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sklearn/cluster/tests/test_k_means.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,14 @@ def test_k_means_fit_predict(algo, dtype, constructor, seed, max_iter, tol):
# There's a very small chance of failure with elkan on unstructured dataset
# because predict method uses fast euclidean distances computation which
# may cause small numerical instabilities.
# NB: This test is largely redundant with respect to test_predict and
# test_predict_equal_labels. This test has the added effect of
# testing idempotence of the fittng procesdure which appears to
Copy link
Member

@ogrisel ogrisel Apr 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "fittng procesdure" but fair enough :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not used to the keyboard on these new macbooks

# be where it fails on some MacOS setups.
if sys.platform == "darwin":
pytest.xfail(
"Known failures on MacOS, See "
"https://github.com/scikit-learn/scikit-learn/issues/12644")
if not (algo == 'elkan' and constructor is sp.csr_matrix):
rng = np.random.RandomState(seed)

Expand Down