[MRG] MNT Extract refit_metric assigment to a private method #12918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract refit_metric assigment to private method _get_refit_metric to simplify complexity of `fit` - Remove unneeded `else` statements inside _get_refit_metric
jnothman
reviewed
Jan 6, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
I don't mind this kind of refactor personally, although the style convention here does tend towards long functions. However, I'd rather avoid a merge conflict with #11354. Perhaps we should suggest a similar refactoring happens over there.
| if not self.multimetric_: | ||
| return 'score' | ||
|
|
||
| if self.refit is not False and ( |
Member
There was a problem hiding this comment.
if we negate this condition and return, the code might be simpler.
| if not self.multimetric_: | ||
| return 'score' | ||
|
|
||
| if self.refit is not False and ( |
Member
There was a problem hiding this comment.
if we negate this condition and return, the code might be simpler.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This is a minor refactoring to simplify the code that lives in method
fit. No functionality was addedsimplify complexity of
fitelsestatements inside _get_refit_metricAny other comments?
The method
fitis too complex in my opinion. This is a step to simplify it.The removal of
elsestatements improves readability and complexif...elselogicAny ideas on how to simplify this method/logic further?